Fix indexing for gpu rand #641
Open
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangnrd
force-pushed
the
fix_rand
branch
from
befeb7a to
1d1ebd9
Compare
|
Thanks for following up! Annoyingly though, test failures seem related. |
christiangnrd
force-pushed
the
fix_rand
branch
from
1d1ebd9 to
7f818e9
Compare
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/testsuite/random.jl b/test/testsuite/random.jl
index 6ecd235..bb493da 100644
--- a/test/testsuite/random.jl
+++ b/test/testsuite/random.jl
@@ -24,7 +24,7 @@
rand!(rng, A)
Random.seed!(rng, 1)
rand!(rng, B)
- @test Array(A) == Array(B) broken=SEEDING_BROKEN && (prod(d) > length(rng.state))
+ @test Array(A) == Array(B) broken = SEEDING_BROKEN && (prod(d) > length(rng.state))
if rng != cpu_rng
rand!(cpu_rng, A)
@@ -64,7 +64,7 @@
randn!(rng, A)
Random.seed!(rng, 1)
randn!(rng, B)
- @test Array(A) == Array(B) broken=SEEDING_BROKEN && (prod(d) > (2 * length(rng.state)))
+ @test Array(A) == Array(B) broken = SEEDING_BROKEN && (prod(d) > (2 * length(rng.state)))
if rng != cpu_rng
randn!(cpu_rng, A) |
|
The fix resurfaced #530, which wasn't detected before because we weren't testing on arrays with length greater than the maximum workgroup size. I think this should be merged once I find a way to properly mark the broken tests because that'll bring us back to where we were before the switch to KA introduced the bug. |
christiangnrd
force-pushed
the
fix_rand
branch
from
5ce03b7 to
62797c8
Compare
|
Failing Metal tests are related but I'll push a fix to mark the test broken once this is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish #615. The issue was that JLArrays wasn't limiting the number of workgroup threads so it was trying to access rand state past 256.
Closes #614
Closes #615